refactor(QM) : commutators#994
Merged
jstoobysmith merged 16 commits intoleanprover-community:masterfrom Mar 22, 2026
Merged
Conversation
Contributor
Author
|
t-quantum-mechanics |
Contributor
Author
|
RFC |
github-actions
bot
added
t-quantum-mechanics
PhysLean/QuantumMechanics/DDimensions/Hydrogen/LaplaceRungeLenzVector.lean
Outdated
Show resolved
Hide resolved
Member
|
Hey, just checking if you want this PR is ready to be reviewed ? |
Contributor
Author
|
Thanks, a review would be much appreciated: all sorries have now been patched up. |
Contributor
Author
|
RFC |
jstoobysmith
approved these changes
Mar 22, 2026
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved: All of these look like good improvements/golfs.
jstoobysmith
added
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves / golfs commutator proofs (cf. #930) making use of Kronecker delta api (cf. #979).
Also adds vanishing commutators as simp lemmas. (This breaks a few LRL proofs that I will fix shortly.)